Honey badger notify no force #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without force option, notify behaves like the old notify_or_ignore
|
Looks reasonable. @olleolleolle let us know if there was a specific reason why |
michaelklishin
approved these changes
Sep 15, 2017
|
@michaelklishin Just me misreading instructions! Carry on! |
|
Cool, thanks @michaelklishin and @olleolleolle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#274 wraps the Honeybadger API to use
notifyafter the removal ofnotify_or_ignore. By default,notifybehaves the same, ignoring notices based on configuration. With theforceoption set totrue, this is changed to notify regardless of whether the notice was configured to be ignored.Hence, I'm removing the
forceoption to restore previous behaviour.